-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance PulsarConsumerTest #12948
Enhance PulsarConsumerTest #12948
Conversation
Jackie-Jiang
commented
Apr 17, 2024
•
edited
Loading
edited
- Reduce fetch timeout so that it needs to fetch multiple batches and test behavior
- Fix producer to properly produce batched messages
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12948 +/- ##
============================================
+ Coverage 61.75% 62.24% +0.49%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136466 +3233
Branches 20636 21120 +484
============================================
+ Hits 82274 84942 +2668
- Misses 44911 45257 +346
- Partials 6048 6267 +219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Got this failure:
Seems like the first 100 messages are somehow reproduced. This aligns with the previous failures |
e785512
to
e4b4c28
Compare
Turns out we were not really publish messages in batches. Fixed the producer to publish in batches and verifies that. |
Fix #8537 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍