Add schema as input to the decoder. #12981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jackie-Jiang Addressed the comment in #12813. Had to close that pull request due to some issues with my local branch. deprecated the no schema init and make the schema init throw an exception by default which is handled in StreamDataProvoder |
rseetham
force-pushed
the
add_schema_decoder
branch
from
b8e087b
to
db41f1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12981 +/- ##
============================================
+ Coverage 61.75% 62.17% +0.42%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136586 +3353
Branches 20636 21145 +509
============================================
+ Hits 82274 84928 +2654
- Misses 44911 45382 +471
- Partials 6048 6276 +228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rseetham
force-pushed
the
add_schema_decoder
branch
from
db41f1e
to
ddefc08
Compare
Jackie-Jiang
added
Configuration
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageDecoder.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageDecoder.java
Outdated
Show resolved
Hide resolved
rseetham
force-pushed
the
add_schema_decoder
branch
5 times, most recently
from
f59bbaf
to
a0cf980
Compare
rseetham
force-pushed
the
add_schema_decoder
branch
from
a0cf980
to
893f4f9
Compare
Comment on lines
1795
to
1800
| try { | ||
| decoder.init(decoderProperties, fieldsToRead, _streamConfig.getTopicName()); | ||
| } catch (UnsupportedOperationException e) { | ||
| // Backward compatibility | ||
| decoder.init(fieldsToRead, _streamConfig, _tableConfig, _schema); | ||
| } |
There was a problem hiding this comment.
With the default fallback in the interface, we should just invoke the new method
...re/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageDecoder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
Jackie-Jiang
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #12521