Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix TextMatchFilterOptimizer boolean grouping #13009

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

itschrispeck
Copy link
Collaborator

Previously the text_match filter optimizer didn't properly push down grouping. For example (tm = text_match):

tm(a) AND (tm(b) OR tm(c))and (tm(a) AND tm(b)) OR tm(c) both were optimized to tm(a AND b OR c)

This PR corrects the behavior to maintain the grouping, e.g.
tm(a) AND (tm(b) OR tm(c)) -> tm(a AND (b OR c))
(tm(a) AND tm(b)) OR tm(c) -> tm((a AND b) OR c)

tag: bugfix

@itschrispeck itschrispeck changed the title bugfix: fix TextMatchFilterOperator boolean grouping bugfix: fix TextMatchFilterOptimizer boolean grouping Apr 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.16%. Comparing base (59551e4) to head (6a02e1c).
Report is 368 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13009      +/-   ##
============================================
+ Coverage     61.75%   62.16%   +0.41%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2502      +66     
  Lines        133233   136586    +3353     
  Branches      20636    21145     +509     
============================================
+ Hits          82274    84906    +2632     
- Misses        44911    45388     +477     
- Partials       6048     6292     +244     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <0.00%> (ø)
java-11 62.16% <100.00%> (+0.45%) ⬆️
java-21 <0.01% <0.00%> (-61.63%) ⬇️
skip-bytebuffers-false 62.15% <100.00%> (+0.41%) ⬆️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin 62.16% <100.00%> (+0.41%) ⬆️
unittests 62.15% <100.00%> (+0.41%) ⬆️
unittests1 46.68% <100.00%> (-0.21%) ⬇️
unittests2 27.96% <0.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 97a2e6d into apache:master Apr 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants