Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use try-with-resources to close file walk stream in LocalPinotFS #13029

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

yashmayya
Copy link
Collaborator

From the File::walk Javadoc:

Screenshot 2024-04-30 at 8 35 13 AM

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base (59551e4) to head (7b8f8ac).
Report is 382 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13029      +/-   ##
============================================
+ Coverage     61.75%   62.17%   +0.42%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2502      +66     
  Lines        133233   136671    +3438     
  Branches      20636    21164     +528     
============================================
+ Hits          82274    84978    +2704     
- Misses        44911    45407     +496     
- Partials       6048     6286     +238     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.14% <100.00%> (+0.43%) ⬆️
java-21 62.06% <100.00%> (+0.43%) ⬆️
skip-bytebuffers-false 62.16% <100.00%> (+0.41%) ⬆️
skip-bytebuffers-true 62.04% <100.00%> (+34.31%) ⬆️
temurin 62.17% <100.00%> (+0.42%) ⬆️
unittests 62.17% <100.00%> (+0.42%) ⬆️
unittests1 46.74% <100.00%> (-0.16%) ⬇️
unittests2 27.94% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashmayya yashmayya marked this pull request as ready for review April 30, 2024 05:44
@Jackie-Jiang Jackie-Jiang merged commit 475708f into apache:master Apr 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants