-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more efficient variants of URLEncoder::encode and URLDecoder::decode #13030
Conversation
9224b02
to
513a866
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13030 +/- ##
=============================================
- Coverage 61.75% 35.03% -26.73%
+ Complexity 207 6 -201
=============================================
Files 2436 2427 -9
Lines 133233 132946 -287
Branches 20636 20612 -24
=============================================
- Hits 82274 46573 -35701
- Misses 44911 82979 +38068
+ Partials 6048 3394 -2654
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...mon/src/test/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtilsTest.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/URIUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
UTF_8
, but this is an easy change anyway. There's also the nice added benefit wherein we no longer need to unnecessarily handle the checkedUnsupportedEncodingException
.