Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark-connector] Add option to fail read when there are invalid segments #13080

Merged
merged 2 commits into from
May 22, 2024

Conversation

cbalci
Copy link
Contributor

@cbalci cbalci commented May 5, 2024

Adding a spark reader option (failOnInvalidSegments) which can be used to fail the read operation, if server response indicated some segments were pruned as invalid.
Also renamed TypeConverter to DataExtractor to better capture what it does.

Testing
Included basic unit tests. Also manually used the included integration test runner to validate the behavior with some invalid segments.

feature

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 62.17%. Comparing base (59551e4) to head (f9451d2).
Report is 408 commits behind head on master.

Files Patch % Lines
...not/connector/spark/datasource/DataExtractor.scala 0.00% 7 Missing ⚠️
.../connector/spark/v3/datasource/DataExtractor.scala 0.00% 7 Missing ⚠️
...k/common/reader/PinotAbstractPartitionReader.scala 0.00% 2 Missing ⚠️
...ector/spark/datasource/PinotDataSourceReader.scala 0.00% 1 Missing ⚠️
...nnector/spark/datasource/PinotInputPartition.scala 0.00% 1 Missing ⚠️
...onnector/spark/v3/datasource/PinotDataSource.scala 0.00% 1 Missing ⚠️
...inot/connector/spark/v3/datasource/PinotScan.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13080      +/-   ##
============================================
+ Coverage     61.75%   62.17%   +0.42%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2507      +71     
  Lines        133233   137800    +4567     
  Branches      20636    21332     +696     
============================================
+ Hits          82274    85679    +3405     
- Misses        44911    45731     +820     
- Partials       6048     6390     +342     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 62.12% <28.57%> (+0.41%) ⬆️
java-21 62.06% <28.57%> (+0.43%) ⬆️
skip-bytebuffers-false 62.14% <28.57%> (+0.40%) ⬆️
skip-bytebuffers-true 62.04% <28.57%> (+34.31%) ⬆️
temurin 62.17% <28.57%> (+0.42%) ⬆️
unittests 62.17% <28.57%> (+0.42%) ⬆️
unittests1 46.85% <ø> (-0.04%) ⬇️
unittests2 27.75% <28.57%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang
Copy link
Contributor

Copy link
Collaborator

@itschrispeck itschrispeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Jackie-Jiang Jackie-Jiang merged commit 3c4fe72 into apache:master May 22, 2024
19 of 20 checks passed
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants