Bugfix: Validate minionInstanceTag during task-generation #13092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13092 +/- ##
============================================
+ Coverage 61.75% 62.20% +0.45%
+ Complexity 207 198 -9
============================================
Files 2436 2514 +78
Lines 133233 137793 +4560
Branches 20636 21321 +685
============================================
+ Hits 82274 85715 +3441
- Misses 44911 45683 +772
- Partials 6048 6395 +347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ankitsultana
reviewed
May 7, 2024
...controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
Outdated
Show resolved
Hide resolved
...controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
Outdated
Show resolved
Hide resolved
ankitsultana
approved these changes
May 8, 2024
|
@tibrewalpratik17 : let's also emit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label:
bugfixminionThis patch validates whether the configured minionInstanceTag actually exists in the list of instance-tags or not. Before this, if a wrong instanceTag was configured for a task, Pinot scheduled those tasks and they got stuck in
IN_PROGRESSstate. Until the task is timed out, no another task scheduling for that table and task type was possible. Or you need to update some minion instance with the specified instanceTag. Ideally, we should error out by throwing an exception for instanceTag not found which this patch achieves.There is a more proactive way of doing this at table-config updation itself. We will try to achieve that when we introduce
minionTenantconfig itself.