bugfix: fix flakey test, avoid early finalization #13095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13095 +/- ##
============================================
+ Coverage 61.75% 62.19% +0.44%
+ Complexity 207 198 -9
============================================
Files 2436 2507 +71
Lines 133233 137785 +4552
Branches 20636 21328 +692
============================================
+ Hits 82274 85697 +3423
- Misses 44911 45697 +786
- Partials 6048 6391 +343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a flakey test issue noticed by @Jackie-Jiang here. Also addresses other tests that could be flakey for the same reason.
For background, see: https://julien.ponge.org/blog/not-all-java-single-threaded-executors-are-created-equal-a-java-finalizer-horror-story/ and https://bugs.openjdk.org/browse/JDK-8145304.
Executors.newSingleThreadExecutorcan only be used in this manner safely in Java 21+.Also verified that non-test code using
Executors.newSingleThreadExecutorlooks safe.tags:
bugfix