Revert "Using local copy of segment instead of downloading from remote" #13114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache#12863)" This reverts commit af8fd40.
|
@klsince - Could you please review ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13114 +/- ##
============================================
+ Coverage 61.75% 62.21% +0.46%
+ Complexity 207 198 -9
============================================
Files 2436 2514 +78
Lines 133233 137790 +4557
Branches 20636 21320 +684
============================================
+ Hits 82274 85722 +3448
- Misses 44911 45671 +760
- Partials 6048 6397 +349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klsince
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12863 until further verification.
Seeing an error after this change, during metadata push, which blocks segments from being uploaded. Any minion task that uses BaseMultipleSegmentsConversionExecutor will run into this error.
java.lang.IllegalArgumentException: File system element for parameter 'path' does not exist: '/home/pinot/data/minionData/SegmentRefreshTask/tmp-f19f9d8f-5f15-4165-8f5b-72673845d172/convertedTarredSegmentDir/refreshed_1715215417793_2_taxitest_0.tar.gz'
at org.apache.commons.io.file.PathUtils.requireExists(PathUtils.java:1467) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at org.apache.commons.io.file.PathUtils.sizeOf(PathUtils.java:1634) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at org.apache.commons.io.FileUtils.lambda$sizeOf$13(FileUtils.java:2863) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at org.apache.commons.io.function.Uncheck.get(Uncheck.java:197) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at org.apache.commons.io.FileUtils.sizeOf(FileUtils.java:2863) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at org.apache.pinot.spi.filesystem.LocalPinotFS.length(LocalPinotFS.java:106) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at org.apache.pinot.spi.filesystem.NoClosePinotFS.length(NoClosePinotFS.java:80) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at org.apache.pinot.controller.api.resources.PinotSegmentUploadDownloadRestletResource.uploadSegment(PinotSegmentUploadDownloadRestletResource.java:308) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at org.apache.pinot.controller.api.resources.PinotSegmentUploadDownloadRestletResource.uploadSegmentAsMultiPartV2(PinotSegmentUploadDownloadRestletResource.java:639) ~[startree-pinot-all-1.2.0-ST.35-jar-with-dependencies.jar:1.2.0-ST.35-50452797ff61e418ecd172cdf7f7090fbf331dec]
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?]