-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a safe version of CLStaticHttpHandler
that disallows path traversal.
#13124
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13124 +/- ##
============================================
+ Coverage 61.75% 62.16% +0.40%
+ Complexity 207 198 -9
============================================
Files 2436 2515 +79
Lines 133233 137862 +4629
Branches 20636 21326 +690
============================================
+ Hits 82274 85696 +3422
- Misses 44911 45772 +861
- Partials 6048 6394 +346
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi, just to mention, I am working on one of the issues along with the little refactoring around swagger-ui itself. refactoring includes the bean creation part. If this bugfix is not urgent, I can incorporate the change in refactoring itself. Here is the draft PR for reference |
c1e78f6
to
bd827d7
Compare
docRoot
param to swaggerui-dist
handler.CLStaticHttpHandler
that disallows path traversal.
Hi, thanks for letting me know. This is kind of urgent as it is fixing path traversal issue. But the changes themselves are quite simple so shouldn't cause much issue with your refactor. |
0f34442
to
492b8ab
Compare
…rsal. Added a safe version of `CLStaticHttpHandler` that disallows path traversal exploits. This is now being used for `swaggerui-dist`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added a safe version of
CLStaticHttpHandler
that disallows path traversal exploits.This is now being used for
swaggerui-dist
.