Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add leaf stage time into broker time #13136

Merged
merged 1 commit into from
May 12, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

Fix the bug where we add the leaf stage execution time into the query time.
Query time should be the wall clock time captured on the broker side

@Jackie-Jiang Jackie-Jiang added bugfix observability multi-stage Related to the multi-stage query engine labels May 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.15%. Comparing base (59551e4) to head (a1eb50e).
Report is 438 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13136      +/-   ##
============================================
+ Coverage     61.75%   62.15%   +0.40%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2515      +79     
  Lines        133233   137859    +4626     
  Branches      20636    21335     +699     
============================================
+ Hits          82274    85692    +3418     
- Misses        44911    45789     +878     
- Partials       6048     6378     +330     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.10% <100.00%> (+0.39%) ⬆️
java-21 62.04% <100.00%> (+0.41%) ⬆️
skip-bytebuffers-false 62.14% <100.00%> (+0.39%) ⬆️
skip-bytebuffers-true 62.00% <100.00%> (+34.27%) ⬆️
temurin 62.15% <100.00%> (+0.40%) ⬆️
unittests 62.15% <100.00%> (+0.40%) ⬆️
unittests1 46.76% <100.00%> (-0.13%) ⬇️
unittests2 27.76% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 7ccd216 into apache:master May 12, 2024
20 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_v2_time branch May 12, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix multi-stage Related to the multi-stage query engine observability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants