Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up vector index comments and exceptions #13150

Merged
merged 1 commit into from
May 14, 2024

Conversation

KKcorps
Copy link
Contributor

@KKcorps KKcorps commented May 14, 2024

No description provided.

@KKcorps KKcorps requested a review from xiangfu0 May 14, 2024 07:11
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.16%. Comparing base (59551e4) to head (1ed1491).
Report is 1001 commits behind head on master.

Files with missing lines Patch % Lines
...nt/index/readers/vector/HnswVectorIndexReader.java 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (1ed1491). Click for more details.

HEAD has 33 uploads less than BASE
Flag BASE (59551e4) HEAD (1ed1491)
integration 7 4
temurin 12 5
java-21 7 4
skip-bytebuffers-true 3 1
skip-bytebuffers-false 7 4
unittests 5 1
unittests1 2 1
java-11 5 1
unittests2 3 0
integration1 2 1
custom-integration1 2 0
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13150       +/-   ##
=============================================
- Coverage     61.75%   35.16%   -26.59%     
+ Complexity      207        6      -201     
=============================================
  Files          2436     2440        +4     
  Lines        133233   134218      +985     
  Branches      20636    20785      +149     
=============================================
- Hits          82274    47199    -35075     
- Misses        44911    83538    +38627     
+ Partials       6048     3481     -2567     
Flag Coverage Δ
custom-integration1 ?
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 0.00% <0.00%> (-61.71%) ⬇️
java-21 35.16% <0.00%> (-26.46%) ⬇️
skip-bytebuffers-false 35.16% <0.00%> (-26.59%) ⬇️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin 35.16% <0.00%> (-26.59%) ⬇️
unittests 46.55% <0.00%> (-15.20%) ⬇️
unittests1 46.55% <0.00%> (-0.34%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 0f48825 into apache:master May 14, 2024
19 of 20 checks passed
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants