Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Ignore field when descriptor does not have filed from fieldsToRead in protobuf codegen decoder #13186

Merged
merged 1 commit into from
May 21, 2024

Conversation

rseetham
Copy link
Contributor

bugfix: In ProtobufCodegenDecoder, to generate the decoder code, during schema update, we might have a case where the input descriptor does not have the FieldDescriptor yet but the column is in the schema. In that case, we will not read that field in. This fix is to make sure the code gen does not fail in such a case

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.23%. Comparing base (59551e4) to head (54894b1).
Report is 471 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13186      +/-   ##
============================================
+ Coverage     61.75%   62.23%   +0.48%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2529      +93     
  Lines        133233   138222    +4989     
  Branches      20636    21389     +753     
============================================
+ Hits          82274    86024    +3750     
- Misses        44911    45780     +869     
- Partials       6048     6418     +370     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.20% <100.00%> (+0.49%) ⬆️
java-21 62.12% <100.00%> (+0.49%) ⬆️
skip-bytebuffers-false 62.22% <100.00%> (+0.47%) ⬆️
skip-bytebuffers-true 62.10% <100.00%> (+34.37%) ⬆️
temurin 62.23% <100.00%> (+0.48%) ⬆️
unittests 62.23% <100.00%> (+0.48%) ⬆️
unittests1 46.72% <ø> (-0.17%) ⬇️
unittests2 27.92% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 661e352 into apache:master May 21, 2024
21 checks passed
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants