Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure brokerId and requestId are always set in BrokerResponse #13200

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

  • Always attach brokerId and requestId, even for errored request
  • Set numUnavailableSegments into RequestContext for multi-stage query

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 62.23%. Comparing base (59551e4) to head (d9c8bab).
Report is 475 commits behind head on master.

Files Patch % Lines
...sthandler/BaseSingleStageBrokerRequestHandler.java 0.00% 3 Missing ⚠️
...requesthandler/MultiStageBrokerRequestHandler.java 0.00% 2 Missing ⚠️
.../org/apache/pinot/broker/querylog/QueryLogger.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13200      +/-   ##
============================================
+ Coverage     61.75%   62.23%   +0.48%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2529      +93     
  Lines        133233   138270    +5037     
  Branches      20636    21399     +763     
============================================
+ Hits          82274    86052    +3778     
- Misses        44911    45797     +886     
- Partials       6048     6421     +373     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.20% <64.70%> (+0.49%) ⬆️
java-21 62.12% <64.70%> (+0.49%) ⬆️
skip-bytebuffers-false 62.22% <64.70%> (+0.47%) ⬆️
skip-bytebuffers-true 62.09% <64.70%> (+34.37%) ⬆️
temurin 62.23% <64.70%> (+0.48%) ⬆️
unittests 62.23% <64.70%> (+0.48%) ⬆️
unittests1 46.73% <ø> (-0.16%) ⬇️
unittests2 27.90% <64.70%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 1feddc4 into apache:master May 21, 2024
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the broker_response_broker_request_id branch May 21, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants