Refactored CommonsConfigurationUtils for loading properties configuration. #13201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13201 +/- ##
============================================
+ Coverage 61.75% 62.22% +0.47%
+ Complexity 207 198 -9
============================================
Files 2436 2531 +95
Lines 133233 138568 +5335
Branches 20636 21450 +814
============================================
+ Hits 82274 86226 +3952
- Misses 44911 45905 +994
- Partials 6048 6437 +389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ation and added UTs.
abhioncbr
changed the title
klsince
approved these changes
May 23, 2024
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
…tion. (apache#13201) * Delete unnecessary setFile call. * Refactored CommonsConfigurationUtils for properties configuration creation and added UTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the PR comment , we are unnecessarily setting the file in case it doesn't exist.
Similarly, for the other functions
fromPath(reference), there is a possibility ofConfigurationException,if provided path value is null.fromInputStream(reference), again there is the possibility of theConfigurationExceptionIn this PR, we handle such scenarios and add the UTs corresponding to the util function.
cc: @klsince / @Jackie-Jiang