Properly return response if SegmentCompletion is aborted

[harold-kfuse]

No description provided.

[harold-kfuse]

cc @Jackie-Jiang

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.23%. Comparing base (59551e4) to head (1b1b481).
Report is 484 commits behind head on master.

Files	Patch %	Lines
.../helix/core/realtime/SegmentCompletionManager.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #13206      +/-   ##
============================================
+ Coverage     61.75%   62.23%   +0.48%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2531      +95     
  Lines        133233   138567    +5334     
  Branches      20636    21448     +812     
============================================
+ Hits          82274    86243    +3969     
- Misses        44911    45882     +971     
- Partials       6048     6442     +394     

Flag	Coverage Δ
custom-integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration	<0.01% <0.00%> (-0.01%)	⬇️
integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration2	0.00% <0.00%> (ø)
java-11	62.18% <0.00%> (+0.47%)	⬆️
java-21	62.12% <0.00%> (+0.50%)	⬆️
skip-bytebuffers-false	62.20% <0.00%> (+0.45%)	⬆️
skip-bytebuffers-true	62.10% <0.00%> (+34.37%)	⬆️
temurin	62.23% <0.00%> (+0.48%)	⬆️
unittests	62.23% <0.00%> (+0.48%)	⬆️
unittests1	46.71% <ø> (-0.18%)	⬇️
unittests2	27.90% <0.00%> (+0.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jackie-Jiang]

Thanks for the fix! Curious if you run into issues with the current code? How did you find this bug?

[harold-kfuse]

Thanks for the fix! Curious if you run into issues with the current code? How did you find this bug?

Yeah. I saw an exception in pinot controller in our cluster. The stacktrace pointed to a null pointer exception (response.toJsonString()) and from logs prior to the stack trace pointed me to this method.