do not fail on duplicate relaxed vars #13214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the double ping @t0mpere. Just letting you know I reopened here after some git issues |
Jackie-Jiang
added
the
Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix to enforce unique, relaxed env variables when loading the PinotConfiguration related to #12307.
Our build system adds the same env variable in 2 formats, and the conversion from _ to . formatting in PinotConfiguration::relaxEnvVarName causes an IllegalStateException because the variables end up with the same name. This change effectively enforces we always take the alphabetically sorted first value instead.
This has no impact on existing users since they would have seen exceptions if they were doing this.