Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs related to FunnelMaxStepAggregationFunction #13228

Merged
merged 1 commit into from
May 25, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

Fix some bugs in newly introduced #13176

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 62.15%. Comparing base (59551e4) to head (65b0472).
Report is 498 commits behind head on master.

Files Patch % Lines
...ction/funnel/FunnelMaxStepAggregationFunction.java 0.00% 11 Missing ⚠️
...y/aggregation/function/funnel/FunnelStepEvent.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13228      +/-   ##
============================================
+ Coverage     61.75%   62.15%   +0.40%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2534      +98     
  Lines        133233   139009    +5776     
  Branches      20636    21537     +901     
============================================
+ Hits          82274    86404    +4130     
- Misses        44911    46140    +1229     
- Partials       6048     6465     +417     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.13% <36.84%> (+0.42%) ⬆️
java-21 62.03% <36.84%> (+0.40%) ⬆️
skip-bytebuffers-false 62.14% <36.84%> (+0.39%) ⬆️
skip-bytebuffers-true 62.00% <36.84%> (+34.27%) ⬆️
temurin 62.15% <36.84%> (+0.40%) ⬆️
unittests 62.15% <36.84%> (+0.40%) ⬆️
unittests1 46.68% <36.84%> (-0.21%) ⬇️
unittests2 27.81% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 518fd18 into apache:master May 25, 2024
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_funnel_step branch May 25, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants