-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FunnelCompleteCount aggregation function #13231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
changed the title
Add FunnelCompleteCount function
Add FunnelCompleteCount aggregation function
May 26, 2024
xiangfu0
force-pushed
the
FunnelCompleteCount-New
branch
2 times, most recently
from
May 26, 2024 06:22
bfb598e
to
1cb05bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13231 +/- ##
============================================
+ Coverage 61.75% 62.05% +0.30%
+ Complexity 207 198 -9
============================================
Files 2436 2539 +103
Lines 133233 139436 +6203
Branches 20636 21575 +939
============================================
+ Hits 82274 86530 +4256
- Misses 44911 46420 +1509
- Partials 6048 6486 +438
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
force-pushed
the
FunnelCompleteCount-New
branch
from
June 2, 2024 08:49
a02d91f
to
c6f4279
Compare
Jackie-Jiang
reviewed
Jun 2, 2024
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java
Outdated
Show resolved
Hide resolved
...pache/pinot/core/query/aggregation/function/funnel/window/FunnelBaseAggregationFunction.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
FunnelCompleteCount-New
branch
5 times, most recently
from
June 3, 2024 04:54
0520ee5
to
fa48a88
Compare
xiangfu0
force-pushed
the
FunnelCompleteCount-New
branch
from
June 3, 2024 07:21
fa48a88
to
987e423
Compare
Jackie-Jiang
approved these changes
Jun 3, 2024
...pache/pinot/core/query/aggregation/function/funnel/window/FunnelBaseAggregationFunction.java
Outdated
Show resolved
Hide resolved
...pache/pinot/core/query/aggregation/function/funnel/window/FunnelBaseAggregationFunction.java
Show resolved
Hide resolved
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
FunnelCompleteCount-New
branch
from
June 4, 2024 00:59
987e423
to
62f25ad
Compare
xiangfu0
force-pushed
the
FunnelCompleteCount-New
branch
from
June 4, 2024 01:00
62f25ad
to
3bcb4ed
Compare
xiangfu0
added
the
release-notes
Referenced by PRs that need attention when compiling the next release notes
label
Jun 4, 2024
xiangfu0
added
the
backward-incompat
Referenced by PRs that introduce or fix backward compat issues
label
Jun 5, 2024
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backward-incompat
Referenced by PRs that introduce or fix backward compat issues
feature
multi-stage
Related to the multi-stage query engine
release-notes
Referenced by PRs that need attention when compiling the next release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunnelCompleteCountAggregationFunction
to calculate how many completed count of funnels;FunnelMatchStepAggregationFunction
to calculate the funnel match array;FunnelBaseAggregationFunction
forFunnelMaxStepAggregationFunction
FunnelCompleteCountAggregationFunction
FunnelMatchStepAggregationFunction
Changed the function syntax a bit to:
E.g.