Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for insufficient number of untagged brokers during tenant creation #13234

Merged
merged 1 commit into from
May 28, 2024

Conversation

yashmayya
Copy link
Collaborator

@yashmayya yashmayya commented May 27, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 35.24%. Comparing base (59551e4) to head (cc291b7).
Report is 499 commits behind head on master.

Files Patch % Lines
...ntroller/helix/core/PinotHelixResourceManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13234       +/-   ##
=============================================
- Coverage     61.75%   35.24%   -26.51%     
=============================================
  Files          2436     2459       +23     
  Lines        133233   135349     +2116     
  Branches      20636    20983      +347     
=============================================
- Hits          82274    47705    -34569     
- Misses        44911    84122    +39211     
+ Partials       6048     3522     -2526     
Flag Coverage Δ
custom-integration1 ?
integration 0.00% <0.00%> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <0.00%> (ø)
java-11 35.24% <0.00%> (-26.47%) ⬇️
java-21 0.00% <0.00%> (-61.63%) ⬇️
skip-bytebuffers-false 35.24% <0.00%> (-26.51%) ⬇️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin 35.24% <0.00%> (-26.51%) ⬇️
unittests 46.65% <ø> (-15.10%) ⬇️
unittests1 46.65% <ø> (-0.24%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 5d9f651 into apache:master May 28, 2024
19 checks passed
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants