Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller host / port / protocol CLI option description for admin commands #13237

Merged

Conversation

yashmayya
Copy link
Collaborator

  • Fix descriptions like Port number to start the controller for commands that are only connecting to the controller (and not starting a controller process).
  • http port -> Port number (since the protocol is a separate config).
  • port name -> Port number.
  • Make casing consistent.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.11%. Comparing base (59551e4) to head (e37ea66).
Report is 499 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13237      +/-   ##
============================================
+ Coverage     61.75%   62.11%   +0.36%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2534      +98     
  Lines        133233   139009    +5776     
  Branches      20636    21537     +901     
============================================
+ Hits          82274    86342    +4068     
- Misses        44911    46192    +1281     
- Partials       6048     6475     +427     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 62.11% <ø> (+0.40%) ⬆️
java-21 <0.01% <ø> (-61.63%) ⬇️
skip-bytebuffers-false 62.11% <ø> (+0.36%) ⬆️
skip-bytebuffers-true <0.01% <ø> (-27.73%) ⬇️
temurin 62.11% <ø> (+0.36%) ⬆️
unittests 62.10% <ø> (+0.36%) ⬆️
unittests1 46.62% <ø> (-0.27%) ⬇️
unittests2 27.80% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 1b16615 into apache:master May 28, 2024
19 checks passed
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants