Fix the issue that map flatten shouldn't remove the map field from the record #13243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13243 +/- ##
============================================
+ Coverage 61.75% 62.16% +0.41%
- Complexity 207 1296 +1089
============================================
Files 2436 2534 +98
Lines 133233 139020 +5787
Branches 20636 21541 +905
============================================
+ Hits 82274 86420 +4146
- Misses 44911 46132 +1221
- Partials 6048 6468 +420
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
force-pushed
the
fix-unnest-logic
branch
from
b819d6a
to
aff08d7
Compare
Jackie-Jiang
approved these changes
May 28, 2024
...l/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug that If a table is configured with
complexTypeConfig, during the ingestionComplexTypeTransformer#flattenMapwould remove all the maps inside the payload.So it's not able to apply transform function on the map field later.