Make allowDownloadFromServer minion-cluster-level config #13247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
release-notes
ankitsultana
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label:
configminionrelease-notesSmall follow-up based on discussion in #12960 (comment)
This patch introduces a minion-cluster level config:
pinot.minion.task.allow.download.from.server(by default false). This config allows minion-tasks to download segments from peers during task-execution.The nature of this config can be overriden by task-level config:
allowDownloadFromServer.If there are lot of tasks in a given cluster, it becomes manual and operational to add the task-level config for all tasks. This cluster-level config simplifies a lot in this scenario.