Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

including the underlying exception in the logging output #13248

Merged
merged 1 commit into from
May 29, 2024

Conversation

fr0stbyte
Copy link
Contributor

This PR includes the underlying NoTaskScheduledException to the logging output. It currently isn't logged. This should help with triaging / debugging efforts in these situations.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.16%. Comparing base (59551e4) to head (a23d90c).
Report is 509 commits behind head on master.

Files Patch % Lines
...roller/api/resources/PinotTaskRestletResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13248      +/-   ##
============================================
+ Coverage     61.75%   62.16%   +0.41%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2534      +98     
  Lines        133233   139012    +5779     
  Branches      20636    21538     +902     
============================================
+ Hits          82274    86420    +4146     
- Misses        44911    46135    +1224     
- Partials       6048     6457     +409     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.12% <0.00%> (+0.41%) ⬆️
java-21 62.05% <0.00%> (+0.43%) ⬆️
skip-bytebuffers-false 62.14% <0.00%> (+0.39%) ⬆️
skip-bytebuffers-true 62.03% <0.00%> (+34.30%) ⬆️
temurin 62.16% <0.00%> (+0.41%) ⬆️
unittests 62.16% <0.00%> (+0.41%) ⬆️
unittests1 46.69% <ø> (-0.20%) ⬇️
unittests2 27.81% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayankshriv mayankshriv merged commit 5a1e57d into apache:master May 29, 2024
19 checks passed
@fr0stbyte fr0stbyte deleted the radu/more_logging_controller branch June 3, 2024 13:58
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants