fixing swagger setup using localhost as host name #13254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @abhioncbr |
Jackie-Jiang
approved these changes
May 29, 2024
abhioncbr
reviewed
May 29, 2024
| @@ -50,12 +50,6 @@ public static void setupSwagger(String componentType, String resourcePackage, bo | |||
| beanConfig.setResourcePackage(resourcePackage); | |||
| beanConfig.setScan(true); | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
Do we want to set the host based on the config for better customization? We can make a separate issue to support that.
There was a problem hiding this comment.
It was introduced in #5941, and doesn't seem required. We can remove it for now and revisit later. This seems like a bug to me
abhioncbr
approved these changes
May 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13254 +/- ##
============================================
+ Coverage 61.75% 62.16% +0.41%
+ Complexity 207 198 -9
============================================
Files 2436 2534 +98
Lines 133233 139016 +5783
Branches 20636 21541 +905
============================================
+ Hits 82274 86419 +4145
- Misses 44911 46135 +1224
- Partials 6048 6462 +414
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
force-pushed
the
fixing-swagger-localhost-issue
branch
from
3a06f96
to
628a5c5
Compare
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced https://github.com/apache/pinot/pull/13122/files#diff-7c6118ecbf342922f9e9288c5fbaf9c8dd3f158895d2a7e4e5582762249ecd06R54
We shouldn't set swagger hostname as localhost, which might not be accessible from the external environment.
E.g. pinot deployed in k8s will using
pinot-controller-1as lcoalhost name, but this hostname is not exposed outside.Current Behavior is using machine hostname:
After fix:
