[bugfix] Handling null value for kafka client id suffix

[tibrewalpratik17]

label:
bugfix

A small follow-up fix to #13168. I recently deployed this patch to one of our clusters and found null getting appending to client id. This patch fixes that issue.

String clientIdSuffix =
        instanceDataManagerConfig != null ? instanceDataManagerConfig.getConsumerClientIdSuffix() : "";
    if (StringUtils.isNotBlank(clientIdSuffix)) {
      clientIdSuffix = "-" + clientIdSuffix;
    }
    _clientId = _tableNameWithType + "-" + streamTopic + "-" + _partitionGroupId + clientIdSuffix;

Above if ciientIdSuffix is null, we were not substituting it with "".

cc @Jackie-Jiang

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.16%. Comparing base (59551e4) to head (d35cde3).
Report is 522 commits behind head on master.

Files	Patch %	Lines
.../starter/helix/HelixInstanceDataManagerConfig.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #13279      +/-   ##
============================================
+ Coverage     61.75%   62.16%   +0.40%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2536     +100     
  Lines        133233   139401    +6168     
  Branches      20636    21548     +912     
============================================
+ Hits          82274    86653    +4379     
- Misses        44911    46259    +1348     
- Partials       6048     6489     +441     

Flag	Coverage Δ
custom-integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration	<0.01% <0.00%> (-0.01%)	⬇️
integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration2	0.00% <0.00%> (ø)
java-11	62.13% <0.00%> (+0.42%)	⬆️
java-21	62.04% <0.00%> (+0.42%)	⬆️
skip-bytebuffers-false	62.15% <0.00%> (+0.40%)	⬆️
skip-bytebuffers-true	62.02% <0.00%> (+34.29%)	⬆️
temurin	62.16% <0.00%> (+0.40%)	⬆️
unittests	62.15% <0.00%> (+0.40%)	⬆️
unittests1	46.74% <ø> (-0.16%)	⬇️
unittests2	27.74% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jackie-Jiang]

Suggest handling null within RealtimeSegmentDataManager constructor:

    String clientIdSuffix =
        instanceDataManagerConfig != null ? instanceDataManagerConfig.getConsumerClientIdSuffix() : null;
    if (StringUtils.isNotBlank(clientIdSuffix)) {
      _clientId = _tableNameWithType + "-" + streamTopic + "-" + _partitionGroupId + "-" + clientIdSuffix;
    } else {
      _clientId = _tableNameWithType + "-" + streamTopic + "-" + _partitionGroupId;
    }

[eaugene]

Thanks for catching this @tibrewalpratik17 .
TIL : null in string concatenation is converted to "null" in java . Ref