Improve warn logs for validDocID snapshot flow #13280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibrewalpratik17
force-pushed
the
improve_logs_compaction
branch
2 times, most recently
from
baa7191
to
c3de33c
Compare
klsince
reviewed
May 30, 2024
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
Outdated
Show resolved
Hide resolved
tibrewalpratik17
force-pushed
the
improve_logs_compaction
branch
from
c3de33c
to
7a7988c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13280 +/- ##
============================================
+ Coverage 61.75% 62.16% +0.40%
+ Complexity 207 198 -9
============================================
Files 2436 2536 +100
Lines 133233 139413 +6180
Branches 20636 21552 +916
============================================
+ Hits 82274 86660 +4386
- Misses 44911 46260 +1349
- Partials 6048 6493 +445
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klsince
approved these changes
May 31, 2024
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
* Improve warn logs for requesting validDocID snapshots * Move verbose logs to debug level and keep some aggregated stats in warn logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label:
bugfixScenario: Upsert compaction runs at a much higher frequency as compared to segment commit. When a segment is compacted, the valid-doc-id snapshot is not available until next commit cycle.
Our logs are flooded with these WARN messages saying snapshot is missing for a segment at every upsert-compaction-task-generator run. The number of log lines is almost equivalent to the number of segments available in the table.
This patch groups all the logs together to not flood the logs and improve the logging experience overall.
cc @snleee @klsince