add metrics tracking lucene near real-time refresh delay #13307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13307 +/- ##
============================================
+ Coverage 61.75% 62.08% +0.32%
+ Complexity 207 198 -9
============================================
Files 2436 2559 +123
Lines 133233 141302 +8069
Branches 20636 21918 +1282
============================================
+ Hits 82274 87723 +5449
- Misses 44911 46910 +1999
- Partials 6048 6669 +621
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chenboat
reviewed
Jun 24, 2024
...java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java
Outdated
Show resolved
Hide resolved
chenboat
reviewed
Jun 24, 2024
...java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java
Outdated
Show resolved
Hide resolved
| @@ -40,4 +40,29 @@ public static void validatePartialOrFullSegmentName(String partialOrFullSegmentN | |||
| throw new IllegalArgumentException("Invalid partial or full segment name: " + partialOrFullSegmentName); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * A util to extract the table name from a segment name. | |||
There was a problem hiding this comment.
I think this can be done in LLCSegmentName already today.
chenboat
approved these changes
Jun 25, 2024
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
* add metrics for lucene nrt delay * license * fix test, mock ServerMetrics * lint * missed mock metrics * missed cherry-pick * close ordering * address comment * use LLCSegmentName instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the realtime Lucene index doesn't immediately make results available to searchers, this can cause confusion for users who see data, then search for it only to get no results. There is currently no visibility into how long they might have to wait for data to be searchable.
This adds two gauges:
These are per partition, and contain the value of the greatest delay across all columns. e.g., if you have two text indexes, on colA, and colB, if colA delay = 10s and colB delay = 20s, the gauge will emit 20s. This is pre-aggregated to avoid high cardinalities which is problematic for many metric systems.
Tested in an internal cluster.
sample delay:
suggested tags:
enhancement,docs