-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getValidDocIdsMetadataFromServer to make call in batches to servers and other bug fixes #13314
Update getValidDocIdsMetadataFromServer to make call in batches to servers and other bug fixes #13314
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13314 +/- ##
============================================
+ Coverage 61.75% 62.04% +0.29%
+ Complexity 207 198 -9
============================================
Files 2436 2544 +108
Lines 133233 139682 +6449
Branches 20636 21606 +970
============================================
+ Hits 82274 86662 +4388
- Misses 44911 46526 +1615
- Partials 6048 6494 +446
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...t-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java
Outdated
Show resolved
Hide resolved
c7372cd
to
00401ec
Compare
00401ec
to
cf5fc2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some comments on variable naming
...oller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/util/CompletionServiceHelper.java
Outdated
Show resolved
Hide resolved
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
Show resolved
Hide resolved
...ava/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java
Outdated
Show resolved
Hide resolved
...t-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java
Show resolved
Hide resolved
aa8a402
to
be38fa3
Compare
be38fa3
to
de73d9f
Compare
pinot-controller/src/main/java/org/apache/pinot/controller/util/CompletionServiceHelper.java
Outdated
Show resolved
Hide resolved
…rvers and other bug fixes (apache#13314) * Update getValidDocIdsMetadataFromServer to make call in batches to server
label:
bugfix
upsert
This patch addresses multiple things:
NOT_FOUND
error. We are moving the failure behaviour of API in this scenario to a warn log instead and continue proceeding to return valid doc ids for whatever segments are available.multiRequestsPerServer
flag and the uri is same for the requests to a server, then only last response will be returned back to the caller. We add a count value to the uri key in this scenario to honour all responses from a single host.cc @klsince @snleee