Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array sum aggregation function #13324

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Jun 6, 2024

  • Support Aggregation function SumArrayLong and SumArrayDouble to aggregate on Arrays to sum on the corresponding array positions.

Sample queries:

SELECT sumArrayLong(longArrayCol), sumArrayDouble(doubleArrayCol) FROM myTable

@xiangfu0 xiangfu0 added feature multi-stage Related to the multi-stage query engine labels Jun 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 5.14706% with 258 lines in your changes missing coverage. Please review.

Project coverage is 61.99%. Comparing base (59551e4) to head (ae27929).
Report is 610 commits behind head on master.

Files Patch % Lines
.../core/operator/docvalsets/RowBasedBlockValSet.java 0.63% 157 Missing ⚠️
...ction/array/SumArrayDoubleAggregationFunction.java 0.00% 49 Missing ⚠️
...unction/array/SumArrayLongAggregationFunction.java 0.00% 49 Missing ⚠️
...gregation/function/AggregationFunctionFactory.java 0.00% 2 Missing ⚠️
...che/pinot/segment/spi/AggregationFunctionType.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13324      +/-   ##
============================================
+ Coverage     61.75%   61.99%   +0.24%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2550     +114     
  Lines        133233   140217    +6984     
  Branches      20636    21795    +1159     
============================================
+ Hits          82274    86929    +4655     
- Misses        44911    46690    +1779     
- Partials       6048     6598     +550     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.97% <5.14%> (+0.26%) ⬆️
java-21 61.86% <5.14%> (+0.24%) ⬆️
skip-bytebuffers-false 61.99% <5.14%> (+0.24%) ⬆️
skip-bytebuffers-true 27.65% <0.00%> (-0.07%) ⬇️
temurin 61.99% <5.14%> (+0.24%) ⬆️
unittests 61.99% <5.14%> (+0.24%) ⬆️
unittests1 46.57% <5.14%> (-0.32%) ⬇️
unittests2 27.66% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 0689175 into apache:master Jun 12, 2024
20 checks passed
@xiangfu0 xiangfu0 deleted the sum-array-agg branch June 12, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation feature multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants