Reposition query submission spot for adaptive server selection #13327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13327 +/- ##
============================================
+ Coverage 61.75% 62.03% +0.28%
+ Complexity 207 198 -9
============================================
Files 2436 2545 +109
Lines 133233 139683 +6450
Branches 20636 21660 +1024
============================================
+ Hits 82274 86656 +4382
- Misses 44911 46476 +1565
- Partials 6048 6551 +503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
reviewed
Jun 7, 2024
| // Record stats related to query submission just before sending the request. Otherwise, if the response is | ||
| // received immediately, there's a possibility of updating query response stats before updating query | ||
| // submission stats. | ||
| _serverRoutingStatsManager.recordStatsAfterQuerySubmission(requestId, serverRoutingInstance.getInstanceId()); |
There was a problem hiding this comment.
Per the method name, this should be put within either markRequestSubmitted() or markRequestSent()
There was a problem hiding this comment.
For low latency usecases at high qps, this can cause the issue mentioned in comments. Hence we update the stats just before submitting.
I've updated the method name to better convey this.
Jackie-Jiang
approved these changes
Jun 8, 2024
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
…e#13327) * Refactor ADSS querysubmission stats to avoid missing servers * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #13104
If there are cases of netty channel lock exceptions, we will avoid publishing stats for some servers as the exception handling breaks out of the loop. With this fix, we will submit stats for all picked servers and at the same time release for all servers.