Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakiness of ControllerPeriodicTasksIntegrationTest #13337

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

Fix #13263

  • Extend the wait time to reduce flakiness
  • Use the new config keys instead of the deprecated keys (deprecated keys are tested within ControllerConfTest)
  • Extract common gauge value comparison logic to improve readability

@Jackie-Jiang Jackie-Jiang marked this pull request as ready for review June 7, 2024 18:37
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.06%. Comparing base (59551e4) to head (0f2c00d).
Report is 576 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13337      +/-   ##
============================================
+ Coverage     61.75%   62.06%   +0.31%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2545     +109     
  Lines        133233   139671    +6438     
  Branches      20636    21657    +1021     
============================================
+ Hits          82274    86691    +4417     
- Misses        44911    46431    +1520     
- Partials       6048     6549     +501     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 62.00% <ø> (+0.30%) ⬆️
java-21 61.95% <ø> (+0.32%) ⬆️
skip-bytebuffers-false 62.05% <ø> (+0.30%) ⬆️
skip-bytebuffers-true 61.89% <ø> (+34.16%) ⬆️
temurin 62.06% <ø> (+0.31%) ⬆️
unittests 62.06% <ø> (+0.31%) ⬆️
unittests1 46.59% <ø> (-0.30%) ⬇️
unittests2 27.76% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit c418442 into apache:master Jun 7, 2024
19 of 20 checks passed
@Jackie-Jiang Jackie-Jiang deleted the controller_periodic_task_test branch June 7, 2024 19:53
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky test] ControllerPeriodicTasksIntegrationTest.testRealtimeSegmentRelocator
3 participants