Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to set segment when use SegmentProcessorFramework #13341

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Jun 7, 2024

set fixedSegmentName for generatorConfig so that one can set segment name when generating segments with SegmentProcessorFramework, and no side effect if the value is null

@klsince klsince added the bugfix label Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.03%. Comparing base (59551e4) to head (d66a853).
Report is 578 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13341      +/-   ##
============================================
+ Coverage     61.75%   62.03%   +0.28%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2545     +109     
  Lines        133233   139684    +6451     
  Branches      20636    21660    +1024     
============================================
+ Hits          82274    86657    +4383     
- Misses        44911    46473    +1562     
- Partials       6048     6554     +506     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.01% <100.00%> (+0.30%) ⬆️
java-21 61.92% <100.00%> (+0.29%) ⬆️
skip-bytebuffers-false 62.02% <100.00%> (+0.28%) ⬆️
skip-bytebuffers-true 61.90% <100.00%> (+34.17%) ⬆️
temurin 62.03% <100.00%> (+0.28%) ⬆️
unittests 62.03% <100.00%> (+0.28%) ⬆️
unittests1 46.57% <100.00%> (-0.32%) ⬇️
unittests2 27.74% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 70412e6 into apache:master Jun 8, 2024
20 checks passed
@apache apache deleted a comment Jun 8, 2024
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants