extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord #13352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Jun 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13352 +/- ##
=============================================
- Coverage 61.75% 0.00% -61.76%
=============================================
Files 2436 2472 +36
Lines 133233 136248 +3015
Branches 20636 21160 +524
=============================================
- Hits 82274 0 -82274
- Misses 44911 136248 +91337
+ Partials 6048 0 -6048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...n/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReader.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord if configured.
Note that dropping deleteRecord too soon may cause the old soft-deleted record to show up unexpectedly, so one should be careful when to skip the deleteRecord. e.g. tombstones from segments older than certain threshold may be dropped safely.
Plus a few fix on code formats