Fix all typed ArrayList elements() method usage #13354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13354 +/- ##
=============================================
- Coverage 61.75% 0.00% -61.76%
=============================================
Files 2436 2473 +37
Lines 133233 136279 +3046
Branches 20636 21171 +535
=============================================
- Hits 82274 0 -82274
- Misses 44911 136279 +91368
+ Partials 6048 0 -6048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/TypeUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
fixing-arraylist-elements-usage
branch
2 times, most recently
from
6eb394a
to
a7f52f2
Compare
xiangfu0
changed the title
Jackie-Jiang
approved these changes
Jun 11, 2024
pinot-common/src/main/java/org/apache/pinot/common/utils/ArrayListUtils.java
Show resolved
Hide resolved
xiangfu0
force-pushed
the
fixing-arraylist-elements-usage
branch
from
a7f52f2
to
1357dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixing for
{Int|Long|Float|Double|Object}ArrayList#elements()call usage.The
ArrayList#elements()returned an array may be longer than the actual size of theArrayList, and the actual size of theArrayListcan be retrieved usingArrayList#size().Created a util class
ArrayListUtilsto best effort extract the givenArrayListto the corresponding primitive array without copying the elements.E.g. this method
ArrayListUtils#toIntArray()checks the length of the returned int array and returns the same if it is equal to the size of the inputIntArrayList, otherwise, it copies the elements to a new int array and returns it.