update RewriterConstants so that expr min max would not collide with columns start with "parent" #13357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13357 +/- ##
============================================
+ Coverage 61.75% 61.99% +0.24%
+ Complexity 207 198 -9
============================================
Files 2436 2550 +114
Lines 133233 140257 +7024
Branches 20636 21801 +1165
============================================
+ Hits 82274 86958 +4684
- Misses 44911 46702 +1791
- Partials 6048 6597 +549
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
update enums and fix tests update RewriterConstants
jasperjiaguo
force-pushed
the
RewriterConstants
branch
from
08bbe70
to
1e905a3
Compare
jasperjiaguo
changed the title
jasperjiaguo
added
the
backward-incompat
jasperjiaguo
changed the title
jackjlli
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated RewriterConstants so that expr min max would not collide with columns start with "parent", tested with unit tests. In production we have turned this on for some cluster having user queries like
select parent_ from Table. These queries collided with the rewriter's flag for parent aggregation function and will run into exceptions likeTagging this
backward incompatas it requires to deploy server and broker to the same version to make theexprmin/exprmaxqueries run correctly.