Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in ArrayAgg extractFinalResult functions #13358

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

xiangfu0
Copy link
Contributor

Fix NPE issue reported in #13343 to extract final result.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 62.11%. Comparing base (59551e4) to head (bc26fa1).
Report is 608 commits behind head on master.

Files Patch % Lines
...ion/function/array/BaseArrayAggDoubleFunction.java 0.00% 1 Missing and 1 partial ⚠️
...tion/function/array/BaseArrayAggFloatFunction.java 0.00% 1 Missing and 1 partial ⚠️
...gation/function/array/BaseArrayAggIntFunction.java 0.00% 1 Missing and 1 partial ⚠️
...ation/function/array/BaseArrayAggLongFunction.java 0.00% 1 Missing and 1 partial ⚠️
...ion/function/array/BaseArrayAggStringFunction.java 0.00% 1 Missing and 1 partial ⚠️
...ry/aggregation/function/array/ListAggFunction.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13358      +/-   ##
============================================
+ Coverage     61.75%   62.11%   +0.35%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2548     +112     
  Lines        133233   139966    +6733     
  Branches      20636    21729    +1093     
============================================
+ Hits          82274    86935    +4661     
- Misses        44911    46438    +1527     
- Partials       6048     6593     +545     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.07% <0.00%> (+0.36%) ⬆️
java-21 61.98% <0.00%> (+0.35%) ⬆️
skip-bytebuffers-false 62.09% <0.00%> (+0.35%) ⬆️
skip-bytebuffers-true 61.95% <0.00%> (+34.22%) ⬆️
temurin 62.11% <0.00%> (+0.35%) ⬆️
unittests 62.10% <0.00%> (+0.35%) ⬆️
unittests1 46.69% <0.00%> (-0.20%) ⬇️
unittests2 27.71% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 5c75b15 into apache:master Jun 11, 2024
20 checks passed
@xiangfu0 xiangfu0 deleted the fixing-array-agg-npe branch June 14, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants