Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored compatibility-verifier module #13359

Merged

Conversation

abhioncbr
Copy link
Contributor

@abhioncbr abhioncbr commented Jun 11, 2024

Labels:

  • refactor
  • cleanup

Description:
In this PR, the focus is mainly on the cleanliness of the code in the pinot-compatibility-verifier module. Here is the summary

  • Writing logs using logger instead of using the system.out
  • leveraging the createSchema return value in table creation operation.
  • Set the default character for the file objects.
  • addressing particular minor warning issues.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 62.01%. Comparing base (59551e4) to head (c196986).
Report is 620 commits behind head on master.

Files Patch % Lines
...src/main/java/org/apache/pinot/compat/TableOp.java 0.00% 8 Missing ⚠️
...rg/apache/pinot/compat/CompatibilityOpsRunner.java 0.00% 5 Missing ⚠️
...rc/main/java/org/apache/pinot/compat/StreamOp.java 0.00% 4 Missing ⚠️
.../src/main/java/org/apache/pinot/compat/BaseOp.java 0.00% 2 Missing ⚠️
...ava/org/apache/pinot/compat/ClusterDescriptor.java 0.00% 1 Missing ⚠️
...src/main/java/org/apache/pinot/compat/QueryOp.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13359      +/-   ##
============================================
+ Coverage     61.75%   62.01%   +0.26%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2550     +114     
  Lines        133233   140256    +7023     
  Branches      20636    21802    +1166     
============================================
+ Hits          82274    86976    +4702     
- Misses        44911    46688    +1777     
- Partials       6048     6592     +544     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.95% <0.00%> (+0.24%) ⬆️
java-21 61.90% <0.00%> (+0.27%) ⬆️
skip-bytebuffers-false 61.98% <0.00%> (+0.24%) ⬆️
skip-bytebuffers-true 61.86% <0.00%> (+34.13%) ⬆️
temurin 62.01% <0.00%> (+0.26%) ⬆️
unittests 62.00% <0.00%> (+0.26%) ⬆️
unittests1 46.58% <ø> (-0.31%) ⬇️
unittests2 27.66% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhioncbr abhioncbr marked this pull request as ready for review June 12, 2024 14:12
@Jackie-Jiang
Copy link
Contributor

I took a look at the compatibility test run, and didn't see any log from BaseOp. Is this expected?

@Jackie-Jiang Jackie-Jiang merged commit 0dd78f1 into apache:master Jun 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants