-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored compatibility-verifier module #13359
Refactored compatibility-verifier module #13359
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13359 +/- ##
============================================
+ Coverage 61.75% 62.01% +0.26%
+ Complexity 207 198 -9
============================================
Files 2436 2550 +114
Lines 133233 140256 +7023
Branches 20636 21802 +1166
============================================
+ Hits 82274 86976 +4702
- Misses 44911 46688 +1777
- Partials 6048 6592 +544
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I took a look at the compatibility test run, and didn't see any log from |
Labels:
refactor
cleanup
Description:
In this PR, the focus is mainly on the cleanliness of the code in the
pinot-compatibility-verifier
module. Here is the summarysystem.out
createSchema
return value in table creation operation.