[HELM]: Added namespace support in K8s deployment. #13380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13380 +/- ##
============================================
+ Coverage 61.75% 61.99% +0.24%
+ Complexity 207 198 -9
============================================
Files 2436 2550 +114
Lines 133233 140286 +7053
Branches 20636 21805 +1169
============================================
+ Hits 82274 86968 +4694
- Misses 44911 46717 +1806
- Partials 6048 6601 +553
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
reviewed
Jun 15, 2024
| @@ -19,6 +19,9 @@ | |||
|
|
|||
| # Default values for Pinot. | |||
|
|
|||
| namespaceOverride: | |||
There was a problem hiding this comment.
is this supported or we should use
namespaceOverride: ~
There was a problem hiding this comment.
Not needed. This is supported.
| {{- if .Values.namespaceOverride -}} | ||
| {{- .Values.namespaceOverride -}} | ||
| {{- else -}} | ||
| {{- .Release.Namespace -}} |
There was a problem hiding this comment.
Is this k8s system default namespace?
what's the behavior if user set the default namespace to something else?
Shall we only define this if user want to?
There was a problem hiding this comment.
Here is the behaviour
- If the
namespaceOverridevalue is provided, it will precede the rest. - If the
namespaceOverridevalue is not provided, and we use the helm command with-n <value>, the provided value in the command will get used. - If both the above values are not provided, then the
defaultvalue will be set as a namespace.
xiangfu0
approved these changes
Jun 20, 2024
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
* Added namespace support in Helm deployment. * Changes for namespace support in pinot helm chart. * minor changes, as per the PR comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels:
KubernetesHelmIn this PR, we support the
namespacein the K8s Helm chart. By default, thenamespacevalue ispinot. We can modify the default value based on needs.