Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode KEEP_ALL in funnel functions to allow adding dummy events for non-matching steps #13382

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Jun 13, 2024

Add mode KEEP_ALL in funnel functions to allow adding dummy events for non-matching steps

Sample query:

SELECT
    userId, 
    funnelMaxStep(
        timestampCol, 
        '1000', 
        3,
        url = '/product/search',
        url = '/checkout/start',
        url = '/checkout/confirmation',
        'strict_order', 
        'keep_all')
FROM myTable 
GROUP BY userId 
ORDER BY userId

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 62.01%. Comparing base (59551e4) to head (3b6cc94).
Report is 616 commits behind head on master.

Files Patch % Lines
...n/funnel/window/FunnelBaseAggregationFunction.java 0.00% 25 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13382      +/-   ##
============================================
+ Coverage     61.75%   62.01%   +0.25%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2550     +114     
  Lines        133233   140272    +7039     
  Branches      20636    21804    +1168     
============================================
+ Hits          82274    86983    +4709     
- Misses        44911    46690    +1779     
- Partials       6048     6599     +551     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.94% <0.00%> (+0.23%) ⬆️
java-21 61.90% <0.00%> (+0.27%) ⬆️
skip-bytebuffers-false 61.98% <0.00%> (+0.23%) ⬆️
skip-bytebuffers-true 61.87% <0.00%> (+34.15%) ⬆️
temurin 62.01% <0.00%> (+0.25%) ⬆️
unittests 62.00% <0.00%> (+0.25%) ⬆️
unittests1 46.56% <0.00%> (-0.33%) ⬇️
unittests2 27.67% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit c341e06 into apache:master Jun 15, 2024
20 checks passed
@xiangfu0 xiangfu0 deleted the funnel-filter-improvement branch June 15, 2024 17:30
@xiangfu0 xiangfu0 changed the title Add mode to allow adding dummy events for non-matching steps Add mode to allow adding dummy events for non-matching steps in funnel functions Jun 21, 2024
@xiangfu0 xiangfu0 changed the title Add mode to allow adding dummy events for non-matching steps in funnel functions Add mode KEEP_ALL in funnel functions to allow adding dummy events for non-matching steps Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants