track segments for snapshotting even if they lost all comparisons #13388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
commented
Jun 13, 2024
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Show resolved
Hide resolved
klsince
commented
Jun 13, 2024
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13388 +/- ##
============================================
+ Coverage 61.75% 62.03% +0.28%
+ Complexity 207 198 -9
============================================
Files 2436 2550 +114
Lines 133233 140262 +7029
Branches 20636 21799 +1163
============================================
+ Hits 82274 87014 +4740
- Misses 44911 46647 +1736
- Partials 6048 6601 +553
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Jun 13, 2024
tibrewalpratik17
approved these changes
Jun 14, 2024
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that docs from a segment lost all comparison with docs from other segments, thus not going to call any of those methods addDocId/replaceDocId where we track segments for snapshotting. So in this PR, we track segments for snapshotting in addSegment/replaceSegment high level entry methods, beside replaceDocId/removeDocId where the existing segments may be updated. This should keep a complete set of segments being updated since last snapshotting.
Also made a fix for another minor bug that some segments were not removed from the track Set after taking snapshot for them.
The batch mode of consistent view feature is also subject to this issue, i.e missing segment that lost all comparison. Will address that in separate RP so that changes can be reverted separately in case.