Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segment size check in OfflineClusterIntegrationTest #13389

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

Segment size is platform dependent because of the native library used by the chunk compressor.
Do not use the hard-coded segment size. Cache the segment size of the generated segments.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.00%. Comparing base (59551e4) to head (7fdf86d).
Report is 619 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13389      +/-   ##
============================================
+ Coverage     61.75%   62.00%   +0.24%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2550     +114     
  Lines        133233   140257    +7024     
  Branches      20636    21801    +1165     
============================================
+ Hits          82274    86960    +4686     
- Misses        44911    46701    +1790     
- Partials       6048     6596     +548     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.97% <ø> (+0.26%) ⬆️
java-21 61.87% <ø> (+0.24%) ⬆️
skip-bytebuffers-false 61.99% <ø> (+0.24%) ⬆️
skip-bytebuffers-true 61.84% <ø> (+34.11%) ⬆️
temurin 62.00% <ø> (+0.24%) ⬆️
unittests 61.99% <ø> (+0.24%) ⬆️
unittests1 46.57% <ø> (-0.32%) ⬇️
unittests2 27.66% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@klsince klsince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jackie-Jiang Jackie-Jiang merged commit 7571f71 into apache:master Jun 13, 2024
20 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_offline_it_test branch June 13, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants