Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make queryWorkerThreads configurable in Pinot server side GrpcQueryServer #13404

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

xiangfu0
Copy link
Contributor

Make queryWorkerThreads configurable in Pinot server side GrpcQueryServer

@xiangfu0 xiangfu0 added the Configuration Config changes (addition/deletion/change in behavior) label Jun 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.98%. Comparing base (59551e4) to head (6cbc3f5).
Report is 632 commits behind head on master.

Files Patch % Lines
...ava/org/apache/pinot/common/config/GrpcConfig.java 0.00% 2 Missing ⚠️
...che/pinot/core/transport/grpc/GrpcQueryServer.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13404      +/-   ##
============================================
+ Coverage     61.75%   61.98%   +0.23%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2550     +114     
  Lines        133233   140288    +7055     
  Branches      20636    21806    +1170     
============================================
+ Hits          82274    86957    +4683     
- Misses        44911    46719    +1808     
- Partials       6048     6612     +564     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.95% <0.00%> (+0.24%) ⬆️
java-21 61.85% <0.00%> (+0.22%) ⬆️
skip-bytebuffers-false 61.97% <0.00%> (+0.22%) ⬆️
skip-bytebuffers-true 61.84% <0.00%> (+34.11%) ⬆️
temurin 61.98% <0.00%> (+0.23%) ⬆️
unittests 61.98% <0.00%> (+0.23%) ⬆️
unittests1 46.56% <0.00%> (-0.33%) ⬇️
unittests2 27.65% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 4615ce5 into apache:master Jun 17, 2024
20 checks passed
@xiangfu0 xiangfu0 deleted the configurable-server-grpc-threads branch June 17, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Config changes (addition/deletion/change in behavior) documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants