Bug fix: Handle missing shade config overwrites for Kafka #13437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrajat
reviewed
Jun 19, 2024
| if (updated) { | ||
| entry.setValue(String.join(" ", valueParts)); | ||
| } | ||
| } | ||
|
|
||
| // Read the file specified by the -Djava.security.auth.login.config VM argument | ||
| String loginConfigFile = System.getProperty("java.security.auth.login.config"); |
There was a problem hiding this comment.
The config file is not in a well-known format like json ?
There was a problem hiding this comment.
xiangfu0
approved these changes
Jun 19, 2024
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
Co-authored-by: Kartik Khare <[email protected]>
yashmayya
pushed a commit
to yashmayya/pinot
that referenced
this pull request
Jul 24, 2024
Co-authored-by: Kartik Khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After multiple shading changes, we had started appending
org.apache.pinot.shadedto the Kafka classpaths that were mentioned in the table config so that we don't run into ClassNotFound errors.This was done in #13087 amd #13056
However, sometimes these classpaths can also be mentioned in the
jaasconfigs in which case they are not updated and hence we still get ClassNotFound errorThis PR adds a way to rename these classapth and also make them part of the table config since ovewriting jaas config file is not correct from security perspective.