Adding registerExtraComponents to allow registering additional components in various services #13465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13465 +/- ##
============================================
+ Coverage 61.75% 62.01% +0.26%
+ Complexity 207 198 -9
============================================
Files 2436 2559 +123
Lines 133233 141311 +8078
Branches 20636 21918 +1282
============================================
+ Hits 82274 87639 +5365
- Misses 44911 47022 +2111
- Partials 6048 6650 +602
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java
Outdated
Show resolved
Hide resolved
soumitra-st
force-pushed
the
register-extra-comp
branch
from
1ea3b46
to
ed8b5b0
Compare
Jackie-Jiang
approved these changes
Jun 25, 2024
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
Outdated
Show resolved
Hide resolved
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
…ents in various services (apache#13465)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding registerExtraComponents after creating instance of the application and before starting to allow registering extra components to various Pinot services.
feature