Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more integration tests to run on the v2 multi-stage query engine #13467

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

yashmayya
Copy link
Collaborator

@yashmayya yashmayya added testing multi-stage Related to the multi-stage query engine labels Jun 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.96%. Comparing base (59551e4) to head (9a8fbc8).
Report is 667 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13467      +/-   ##
============================================
+ Coverage     61.75%   61.96%   +0.21%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2557     +121     
  Lines        133233   141190    +7957     
  Branches      20636    21913    +1277     
============================================
+ Hits          82274    87487    +5213     
- Misses        44911    47044    +2133     
- Partials       6048     6659     +611     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.93% <ø> (+0.22%) ⬆️
java-21 35.28% <ø> (-26.35%) ⬇️
skip-bytebuffers-false 61.94% <ø> (+0.19%) ⬆️
skip-bytebuffers-true 35.26% <ø> (+7.53%) ⬆️
temurin 61.96% <ø> (+0.21%) ⬆️
unittests 61.95% <ø> (+0.21%) ⬆️
unittests1 46.67% <ø> (-0.22%) ⬇️
unittests2 27.49% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashmayya yashmayya marked this pull request as ready for review June 24, 2024 12:26
@yashmayya yashmayya requested a review from gortiz June 24, 2024 12:26
@Jackie-Jiang Jackie-Jiang merged commit 9ccd1be into apache:master Jun 24, 2024
20 checks passed
suyashpatel98 pushed a commit to suyashpatel98/pinot that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-stage Related to the multi-stage query engine testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants