Removing legacy commons-lang dependency #13480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13480 +/- ##
============================================
+ Coverage 61.75% 62.05% +0.30%
+ Complexity 207 198 -9
============================================
Files 2436 2559 +123
Lines 133233 141302 +8069
Branches 20636 21918 +1282
============================================
+ Hits 82274 87688 +5414
- Misses 44911 46959 +2048
- Partials 6048 6655 +607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abhioncbr
added
cleanup
dependencies
Jackie-Jiang
approved these changes
Jun 26, 2024
| @@ -181,7 +181,7 @@ public File createAvroFile() | |||
| for (int i = 0; i < getCountStarResult(); i++) { | |||
| // create avro record | |||
| GenericData.Record record = new GenericData.Record(avroSchema); | |||
| record.put(ID, RandomUtils.nextInt(10)); | |||
| record.put(ID, RandomUtils.nextInt(0, 10)); | |||
There was a problem hiding this comment.
Seems RandomUtils is already deprecated. Can you replace it with a regular Random?
There was a problem hiding this comment.
I did notice the deprecation warning. I plan to use commons-rng as it's much more performant than java.util.Random in the follow-up PR. Thoughts?
This was referenced Jun 27, 2024
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels
dependenciescleanupDescription