ControllerRequestClient accepts headers. Useful for authN tests #13481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authN tests can pass authentication parameters using headers. Allow initialization of ControllerRequestClient with headers so that it can be used in authN tests as well. As an example, UrlAuthRealtimeIntegrationTest has been modified to use ControllerRequestClient initialized with headers. The implementation is now simpler than before.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13481 +/- ##
============================================
+ Coverage 61.75% 62.05% +0.30%
+ Complexity 207 198 -9
============================================
Files 2436 2560 +124
Lines 133233 141365 +8132
Branches 20636 21929 +1293
============================================
+ Hits 82274 87726 +5452
- Misses 44911 46980 +2069
- Partials 6048 6659 +611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
approved these changes
Jun 28, 2024
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
…he#13481) authN tests can pass authentication parameters using headers. Allow initialization of ControllerRequestClient with headers so that it can be used in authN tests as well. As an example, UrlAuthRealtimeIntegrationTest has been modified to use ControllerRequestClient initialized with headers. The implementation is now simpler than before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authN tests can pass authentication parameters using headers. Allow initialization of ControllerRequestClient with headers so that it can be used in authN tests as well. As an example, UrlAuthRealtimeIntegrationTest has been modified to use ControllerRequestClient initialized with headers. The implementation is now simpler than before.
tags:
refactor