Allow PintoHelixResourceManager subclasses to be used in the controller starter by providing an overridable PinotHelixResouceManager object creator function #13495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er starter by providing an overridable PinotHelixResouceManager object creator function
9aman
force-pushed
the
include_subclassing_capabilites_for_pinot_helix_resource_manager
branch
2 times, most recently
from
4ae2dca
to
165d96f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13495 +/- ##
============================================
+ Coverage 61.75% 62.02% +0.27%
+ Complexity 207 198 -9
============================================
Files 2436 2559 +123
Lines 133233 141362 +8129
Branches 20636 21928 +1292
============================================
+ Hits 82274 87682 +5408
- Misses 44911 47021 +2110
- Partials 6048 6659 +611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…propertyStore to allow access from subclasses.
9aman
force-pushed
the
include_subclassing_capabilites_for_pinot_helix_resource_manager
branch
from
165d96f
to
5cf1066
Compare
klsince
reviewed
Jun 27, 2024
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
Outdated
Show resolved
Hide resolved
…eControllerStarter.java Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
9aman
force-pushed
the
include_subclassing_capabilites_for_pinot_helix_resource_manager
branch
from
145b80a
to
7bdcf16
Compare
klsince
approved these changes
Jun 28, 2024
…an be used instead.
9aman
force-pushed
the
include_subclassing_capabilites_for_pinot_helix_resource_manager
branch
from
7bdcf16
to
c04ed24
Compare
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
…er starter by providing an overridable PinotHelixResouceManager object creator function (apache#13495) * Allow PintoHelixResourceManager subclasses to be used in the controller starter by providing an overridable PinotHelixResouceManager object creator function --------- Co-authored-by: Aman Khanchandani <[email protected]> Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
yashmayya
pushed a commit
to yashmayya/pinot
that referenced
this pull request
Jul 24, 2024
…er starter by providing an overridable PinotHelixResouceManager object creator function (apache#13495) * Allow PintoHelixResourceManager subclasses to be used in the controller starter by providing an overridable PinotHelixResouceManager object creator function --------- Co-authored-by: Aman Khanchandani <[email protected]> Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Scenario
In
BaseControllerStarter, thePinotHelixResourceManager _helixResourceManagerinitialization is hard coded to the PinotHelixResourceManager object.This reduces the flexibility of using subclasses of PinotHelixResourceManager in any subclass of the
BaseControllerStarter.Changes in the PR
Introduce an overridable function for initialization of PinotHelixResourceManager _helixResourceManager. Thus, any subclass of PinotHelixResourceManager can be used for initialization in the subclass of
BaseControllerStarter.