-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors gracefully during multi-stage stats collection in the broker #13496
Handle errors gracefully during multi-stage stats collection in the broker #13496
Conversation
yashmayya
commented
Jun 27, 2024
- There exist certain edge cases during multi-stage stats collection at the broker that can result in exceptions because the stats are generated by the physical operators but the info available to construct the tree is the logical operators.
- Currently, any such exceptions will propagate all the way up to here and will result in the query failing.
- Instead, we should log the error and indicate it in the stats response while still returning the actual query results.
...ker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13496 +/- ##
=============================================
- Coverage 61.75% 35.27% -26.48%
+ Complexity 207 6 -201
=============================================
Files 2436 2484 +48
Lines 133233 137678 +4445
Branches 20636 21372 +736
=============================================
- Hits 82274 48570 -33704
- Misses 44911 85422 +40511
+ Partials 6048 3686 -2362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |