Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors gracefully during multi-stage stats collection in the broker #13496

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

yashmayya
Copy link
Collaborator

  • There exist certain edge cases during multi-stage stats collection at the broker that can result in exceptions because the stats are generated by the physical operators but the info available to construct the tree is the logical operators.
  • Currently, any such exceptions will propagate all the way up to here and will result in the query failing.
  • Instead, we should log the error and indicate it in the stats response while still returning the actual query results.

@yashmayya yashmayya requested a review from gortiz June 27, 2024 07:13
@yashmayya yashmayya added the multi-stage Related to the multi-stage query engine label Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 35.27%. Comparing base (59551e4) to head (0026e3c).
Report is 683 commits behind head on master.

Files Patch % Lines
...requesthandler/MultiStageBrokerRequestHandler.java 0.00% 13 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (0026e3c). Click for more details.

HEAD has 26 uploads less than BASE | Flag | BASE (59551e4) | HEAD (0026e3c) | |------|------|------| |integration|7|5| |temurin|12|6| |java-21|7|5| |skip-bytebuffers-false|7|2| |unittests|5|1| |unittests1|2|1| |java-11|5|1| |integration1|2|1| |custom-integration1|2|1|
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13496       +/-   ##
=============================================
- Coverage     61.75%   35.27%   -26.48%     
+ Complexity      207        6      -201     
=============================================
  Files          2436     2484       +48     
  Lines        133233   137678     +4445     
  Branches      20636    21372      +736     
=============================================
- Hits          82274    48570    -33704     
- Misses        44911    85422    +40511     
+ Partials       6048     3686     -2362     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 0.00% <0.00%> (-61.71%) ⬇️
java-21 35.27% <0.00%> (-26.35%) ⬇️
skip-bytebuffers-false 0.00% <0.00%> (-61.75%) ⬇️
skip-bytebuffers-true 35.27% <0.00%> (+7.55%) ⬆️
temurin 35.27% <0.00%> (-26.48%) ⬇️
unittests 46.51% <ø> (-15.24%) ⬇️
unittests1 46.51% <ø> (-0.38%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gortiz gortiz merged commit 0b326c6 into apache:master Jun 27, 2024
19 of 20 checks passed
suyashpatel98 pushed a commit to suyashpatel98/pinot that referenced this pull request Jul 6, 2024
yashmayya added a commit to yashmayya/pinot that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants